search

bitcrowd / tickety-tick

A browser extension that helps you name branches and write better commit messages
MIT License
57 stars 10 forks source link

Fix version number for local Chrome releases #255

Closed klappradla closed 1 year ago

klappradla commented 4 years ago

The Github-release workflow sketched out in #249 uploads a bundled Chrome release to Github. The contents of this archive are intended for "local" installations in Chrome.

Due to Mozilla not allowing us to sign the same version as "listed" and "unlisted" in Firefox Add Ons, we appended an unlisted string to the version name. Unfortunately this makes the version name then incompatible with Chrome 🤯.

One cannot install the released version as unpacked extension in Chrome:

Screenshot 2020-07-01 at 09 58 16

We need to find a way to have the custom version name either only in Firefox or change the pattern to be compatible with Chrome as well.

klappradla commented 1 year ago

After some changes to Mozilla's Add-Ons API, we are now able to automatically submit listed releases and also obtain an artifact for manual installation 🎉. See #296 for the progress on that.

The [v5.1.0] https://github.com/bitcrowd/tickety-tick/releases/tag/v5.1.0 release already has an .xpi file for local installation.

So we can close this issue and continue our SemVer version naming like we did.