search

bitcrowd / tickety-tick

A browser extension that helps you name branches and write better commit messages
MIT License
57 stars 10 forks source link

[#270] GitLab integration is broken #271

Closed taig closed 3 years ago

taig commented 3 years ago

Implements a new approach to extract the ticket id from a GitLab issue page. The previously used id js-issuable-app-initial-data is no longer present in the source. However the legacy approach is left in place to support older self-hosted GitLab installations.

I tested the development build with Chrome on the GitLab page to confirm it's working.

Closes #270

klappradla commented 3 years ago

Yay, thanks a ton for jumping onto this @Taig 👏

I just briefly checked your implementation on gitlab.com and a self hosted version. Looking good 💯

taig commented 3 years ago

Therefore: do we even know if it's necessary to support the legacy approach any more? Or is this targeting a version of Gitlab which pretty much no one is using any more?

The body attribute was probably introduced 10 months ago. I clicked my way through 10 popular GitLab instances, all of which had a recent enough installation except for Mastodon. It's up to you to decide whether the legacy support can already be dropped. But I also don't mind making the changes to the code that you suggested.

klappradla commented 3 years ago

The body attribute was probably introduced 10 months ago. I clicked my way through 10 popular GitLab instances, all of which had a recent enough installation except for Mastodon.

Wow, what an awesome research 💯

Then let's stay with the legacy support for now 👍