search

bitcrowd / tickety-tick

A browser extension that helps you name branches and write better commit messages
MIT License
57 stars 10 forks source link

Update terminal notification setup #337

Closed klappradla closed 2 years ago

klappradla commented 2 years ago

As it turned out in https://github.com/bitcrowd/tickety-tick/pull/336, the webpack-build-notifier package we're using in development isn't compatible with Apple's new M1 architecture and probably won't in the near future. See this issue for some background on this.

How should we proceed on this:

  1. Find an alternative more future-proof setup?
  2. Get rid of the terminal notifications altogether?
pmeinhardt commented 2 years ago

I suppose one could try to conditionally disable the plugin on Apple Silicon - possibly using Node.js' os.arch() or process.arch – but at that point I'd be leaning towards removing the dependency. 🙂

pmeinhardt commented 2 years ago

…under the assumption it's a runtime error, not one at install-time. I don't have an M1, so I can't tell. 🙂

tessi commented 2 years ago

👋 to be honest, I have no idea what the error is about or where it's triggered. But I have an M1 mac at hand and could test whatever you want me to test :)

klappradla commented 2 years ago

Thanks @pmeinhardt & @tessi 💚

I also have an M1 and could test it there. But I prefer to have the setup run quick and friction-less for anyone looking to contribute. The extra complexity and respective maintenance effort just for the sake of the build notification does not feel worth the effort to me. The time would be better spend speeding up the build itself 😉

Therefore going with simply removing the notifier 🧹