search

bitdefender / bddisasm

bddisasm is a fast, lightweight, x86/x64 instruction decoder. The project also features a fast, basic, x86/x64 instruction emulator, designed specifically to detect shellcode-like behavior.
Apache License 2.0
874 stars 112 forks source link

reserved identifier violation #5

Closed elfring closed 4 years ago

elfring commented 4 years ago

I would like to point out that identifiers like “_MNEMONICS_H_” and “_TABLE_VEX_H_” do eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

ianichitei commented 4 years ago

This is a problem indeed. I'll take a look at it and I will change the include guards, but this will happen most likely Monday.

Speaking of C++, I think we can make another improvement and add extern "C" to our public headers, but that's another issue.

elfring commented 4 years ago

Thanks for your adjustment of affected include guards.