search

bitemyapp / bloodhound

Haskell Elasticsearch client and query DSL
bitemyapp.com
BSD 3-Clause "New" or "Revised" License
424 stars 118 forks source link

Add helper data types and functions for Missing Aggregations #105

Closed MHova closed 8 years ago

MHova commented 8 years ago

It's funny what you discover once you start eating your own dog food =)

Add the MissingResult data type (akin to TermsResult) and toMissing helper function for parsing MissingResults from AggregationResults.

MichaelXavier commented 8 years ago

@bitemyapp This looks good to me. The more of these we have to do the sillier it will look, since they all have the same definition, but I think having the explicit APIs for parsing these results is better signage than one with a FromJSON constraint.

bitemyapp commented 8 years ago

@MichaelXavier most of the point is the UX wrapped around the JSON parsing bits anyway. We can try to unify it by some other means later, but I'm fine chucking it in as-is like this for now. Thank you for reviewing this!

bitemyapp commented 8 years ago

@MHova and thank you for PR'ing this! :+1: :fireworks: :bear: :bear:

MHova commented 8 years ago

:+1: :joy: