search

bitemyapp / bloodhound

Haskell Elasticsearch client and query DSL
bitemyapp.com
BSD 3-Clause "New" or "Revised" License
424 stars 118 forks source link

doco appears to be wrong for advanceScrollId #113

Closed mwotton closed 8 years ago

mwotton commented 8 years ago

afaict, a scrollId will always be returned (at least in elasticsearch 2.1.1) - signalling appears to be done by having an empty list of hits.

MHova commented 8 years ago

The docs are indeed wrong! I pointed this out previously and provided a fix. The fix is in master, but hasn't been released yet.

mwotton commented 8 years ago

Oops, my apologies :)

On Mon, 7 Mar 2016 6:36 pm Michael Ho notifications@github.com wrote:

The docs are indeed wrong! I pointed this out previously https://github.com/bitemyapp/bloodhound/issues/95 and provided a fix https://github.com/bitemyapp/bloodhound/pull/96. The fix is in master, but hasn't been released yet.

— Reply to this email directly or view it on GitHub https://github.com/bitemyapp/bloodhound/issues/113#issuecomment-193507937 .

bitemyapp commented 8 years ago

@MHova @mwotton should be released now, 0.11.0.0 was Thu Mar 3 18:32:31 UTC 2016 by bitemyapp

MHova commented 8 years ago

Ah great!

bitemyapp commented 8 years ago

Closing this unless someone says current docs aren't right.