search

bitemyapp / bloodhound

Haskell Elasticsearch client and query DSL
bitemyapp.com
BSD 3-Clause "New" or "Revised" License
424 stars 118 forks source link

Switch derive to generics-sop #155

Closed phadej closed 8 years ago

phadej commented 8 years ago

Until https://github.com/nick8325/quickcheck/pull/112 is merged and released

AFAICS, this is the last bit, so we can put bloodhound back on Stackage again.

MichaelXavier commented 8 years ago

Thanks for this! I'm not holding my breath on that PR escaping the shadow realm any time soon. I'll be implementing this on my own packages that are depending on derive for arbitrary instances.

MichaelXavier commented 8 years ago

@bitemyapp Any objection to merging this? According to stackage bloodhound is disabled from nightlies due to derive and "aeson 1.0". I assume that means it didn't support aeson 1.0 but now its < 1.1 so we should be good there. I'm on a tear going through all my packages and getting them back on stackage and katip-elasticsearch I think is blocked on bloodhound. I move that we move for a release, so I'll look at the other outstanding PRs, then we can write up a changelog and release!

bitemyapp commented 8 years ago

@MichaelXavier yep, I'll merge this now. Just keep pinging if you need anything or think it's time to cut the release.

MichaelXavier commented 8 years ago

I doubt the last standing PR is going to get resolved soon, so I will go ahead and review the diff between last released version and master, choose an appropriate version bump, update the changelog and submit a PR for release.

bitemyapp commented 8 years ago

@MichaelXavier sounds good, thank you!