search

bitemyapp / bloodhound

Haskell Elasticsearch client and query DSL
bitemyapp.com
BSD 3-Clause "New" or "Revised" License
424 stars 118 forks source link

Aeson 1.1 #165

Closed MichaelXavier closed 7 years ago

MichaelXavier commented 7 years ago

This is for #162. Tests pass for me. We'll see what travis says. Note that I specifically force aeson 1.1 in stack-8.0.yaml to make sure its tested in aeson. It isn't in any actual stackage releases at the moment so you'll have to do something like this no matter what.

bitemyapp commented 7 years ago

@MichaelXavier I merged this because it looked fine, but should we have bumped the extra-dep in stack.yaml to test it in CI?

MichaelXavier commented 7 years ago

The test matrix actually selects the appropriate stack yaml based on the GHC version, so the matrix entry for GHC 8 will exercise aeson-1.1 in travis. We could force it through to the other GHC versions but that will require a lot more version tetris in their stack.yaml files and I figure we're just after a smoke test anyways.

bitemyapp commented 7 years ago

@MichaelXavier sounds fine to me, thank you!