Relax the dependency on containers and allow building the test suite with GHC 8.6

bitemyapp / bloodhound

Haskell Elasticsearch client and query DSL

bitemyapp.com

BSD 3-Clause "New" or "Revised" License

424 stars 118 forks source link

Relax the dependency on containers and allow building the test suite with GHC 8.6 #246

Closed 23Skidoo closed 5 years ago

23Skidoo commented 6 years ago

NB: This PR drops support for GHC < 8. I'm not sure whether it is okay or not. Looks like there is no CI for GHC < 8, though.

Would be also nice if the dependency on containers was relaxed on Hackage or a new minor release with support for GHC 8.6 was uploaded.

MichaelXavier commented 5 years ago

@bitemyapp i kicked the build and it passed. Any objection to dropping GHC 7.x support? If not, I can prepare a release. @23Skidoo this would constitute a C version bump as in A.B.C, right? Types didn't change but a newer version of dependencies is now required, which may introduce orphan instances or whatever.

23Skidoo commented 5 years ago

Yep, there are no orphan instances in containers AFAICT (otherwise a major version bump could be required).

23Skidoo commented 5 years ago

Ping.

bitemyapp commented 5 years ago

Fixed by #258. No upper bounds now.