Closed soareschen closed 4 years ago
There are multiple conflicts.
The conflicts are because the PR is configured to merge against master, while it should have merge with the 0.16.0.0
tag. But I can't create a PR for a git tag, and there is no branch corresponding to 0.16.0.0.
Can we please get this PR merged against 4c743e1082b8b5eec53a7155733999441be0efce (0.16.0.0) and released as 0.16.0.1 so that downstream packages work with GHC 8.8 and 8.10? It's 5 minutes of work. @bitemyapp @MichaelXavier
@bitemyapp @MichaelXavier
Ping
@arybczak @wraithm
Fix the merge conflicts and I'll review with an intent to merge if there aren't issues. Looks sundry to me.
@bitemyapp The problem is that this should be merged into 0.16.0.0, as OP mentioned. I don't think it makes sense to merge this into master. Is there some way to make a pull request target that specific commit without a tag or an existing branch? What are your thoughts?
@wraithm I'm not entirely sure what you are asking for. Could you please explain in more explicit terms what it is you want me to do?
I'd like you to create a branch at hash 4c743e1082b8b5eec53a7155733999441be0efce
for this PR to target. The branch should probably be called 0.16
or something like that. This PR should then be merged into that branch and released onto hackage as 0.16.1.0 or something like that.
This PR should target 0.16, not 0.17, and therefore should be merged into or based on the last 0.16 commit. However, we cannot make the branch for you. You need to do that.
I cut releases from master
. I won't make an exception here. Sorry!
@bitemyapp what can we do to get GHC 8.8 support before the next major version of bloodhound
is out?
@bitemyapp I'm happy to do the maintenance work here.
@wraithm 君の番だよ
ありがとうございました、Chrisさん。
いつでも君の君になります。私が日本語を話すのをどうやって知っていますか?
While waiting for the next major release of Bloodhound, we'd like to use the current released version (0.16.0.0) with GHC 8.8 and 8.10 support. I'd appreciate if you can do a minor release 0.16.0.1 to make life easier for current users.
This change is