search

bitemyapp / bloodhound

Haskell Elasticsearch client and query DSL
bitemyapp.com
BSD 3-Clause "New" or "Revised" License
422 stars 118 forks source link

Should `putMapping` really be deprecated? #294

Open supersven opened 1 week ago

supersven commented 1 week ago

Though, having multiple mapping types per index is deprecated (https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html), updating the mapping of an index seems to be still a valid operation (https://www.elastic.co/guide/en/elasticsearch/reference/8.15/indices-put-mapping.html).

So, I'm wondering if I got this wrong or if putMapping (Database.Bloodhound.Common.Requests and Database.Bloodhound.Common.Client) should better not be annotated as DEPRECATED? :thinking:

blackheaven commented 1 week ago

Thanks for noticing it, actually ElasticSearch 8 isn't supported (yet).

I think it's worth moving it in version-specific modules and deprecating or not according to the documentation.