search

bitemyapp / brotli2-rs

Brotli encoders/decoers for Rust
Apache License 2.0
28 stars 13 forks source link

targets brotli 1.0 branch #25

Closed DoumanAsh closed 5 years ago

DoumanAsh commented 5 years ago

There was only remouval of deprecated methods which are not used by crate.\

All C files are stored in c directory now, I included to build all necessary files, but not every one

A bit unsure right now what exacly caused example test to fail

alexcrichton commented 5 years ago

Thanks! Looks good to me, but CI appears to be failing?

DoumanAsh commented 5 years ago

@alexcrichton Yes, it seems something changed in brotli internally and example has some failures due to https://github.com/alexcrichton/brotli2-rs/blob/master/src/write.rs#L151 It seems it needs more output but it didn't consume input at all

Since I'm not very well familiar with brotli API, I'm not sure what's going on there exactly. For now I'm trying to prototype myself to get a hang of it.

alexcrichton commented 5 years ago

Ah sorry I don't have the time to help debug this, but I'm pretty confident in CI so if it's working there seems fine to merge!

DoumanAsh commented 5 years ago

The way it looks, at some point brotli starts returning NeedOutput despite Write interface periodically taking bytes out of it. It is not even consuming any input once it happens. Which looks like bug there but I'm not all that sure