bitemyapp / esqueleto

New home of Esqueleto, please file issues so we can get things caught up!
BSD 3-Clause "New" or "Revised" License
372 stars 107 forks source link

Lateral joins #212

Closed belevy closed 3 years ago

belevy commented 3 years ago

Before submitting your PR, check that you've:

After submitting your PR:


Fixes #121

I am not particularly happy with the extra *Lateral constructors on the From GADT. If you can come up with a better way please do. Once again the TypeError's have caused so many headaches. Because they need the catchall overlappable instances the only way I could satisfy the compiler was by making new classes with an extra type parameter that is generated using the IsLateral type family. Once again I am very open to suggestions on how to make this implementation less awful but I like the syntax for the end user.

belevy commented 3 years ago

subsumed by #215