bitemyapp / esqueleto

New home of Esqueleto, please file issues so we can get things caught up!
BSD 3-Clause "New" or "Revised" License
372 stars 107 forks source link

Consolidate Tests #261

Closed parsonsmatt closed 3 years ago

parsonsmatt commented 3 years ago

This PR consolidates the test suite and provides a means of further factoring things out from it.

Performing stack clean && time stack test --fast esqueleto on master and this branch yield a runtime of 2:25 vs 1:47, about 30s of savings.

Incremental builds are even faster. Factoring out the models into a separate module has a considerable benefit on compile-times. Performing a build (stack build --test --no-run-tests --fast esquleto) and then editing Common.Test to have an additional test case on master results in a rebuild that takes 54s of wall time. On this branch, the same change takes 12s to rebuild.

Before submitting your PR, check that you've:

After submitting your PR: