bitemyapp / esqueleto

New home of Esqueleto, please file issues so we can get things caught up!
BSD 3-Clause "New" or "Revised" License
376 stars 108 forks source link

Add `selectOne` #265

Closed ibarrae closed 3 years ago

ibarrae commented 3 years ago

Closes #257

Before submitting your PR, check that you've:

After submitting your PR:

belevy commented 3 years ago

I'd prefer that the function be called selectFirst, unfortunately that would technically be a major API break since we're re-exporting persistent. Perhaps we could put this in the release that removes the old syntax?

ibarrae commented 3 years ago

I'd prefer that the function be called selectFirst, unfortunately that would technically be a major API break since we're re-exporting persistent. Perhaps we could put this in the release that removes the old syntax?

Thanks for the quick reply @belevy :) I was wondering about that, to avoid conflicts with existent persistent function, thus I thought as a workaround (for now) to get it called in a different way.

And correct me if I'm wrong, but you are mentioning to put this as part of ~4.0.0.0~ 3.6 right?

belevy commented 3 years ago

@parsonsmatt Correct me if I'm wrong but this would require a bump in the major version right i.e 4.0.0

parsonsmatt commented 3 years ago

esqueleto uses PVP versioning so we could put this out with selectFirst as an esqueleto function with 3.6.0.0

ibarrae commented 3 years ago

Thanks for all the suggestions @belevy @parsonsmatt, I updated the branch accordingly and also updated the version number. Any more feedback is more than welcome :tada:

parsonsmatt commented 3 years ago

released! thanks 😄