Avoid generating an empty list as the left operand to NOT IN

cdparks commented 3 years ago

Postgres treats x in () and x not in () as syntax errors. Instead translate:

  x in ()      ⇒  FALSE
  x not in ()  ⇒  TRUE

Older versions of esqueleto did both of these, but apparently the latter got lost in the most recent version. See issue #272.

Before submitting your PR, check that you've:

[x] Bumped the version number. ~~I'm not sure what the version number should be, looks like esqueleto uses PVP?~~ I bumped the smallest component to 3.5.2.1 since this is a bugfix
[ ] Documented new APIs with Haddock markup. N/A
[ ] Added @since declarations to the Haddock. N/A
[x] Ran stylish-haskell and otherwise adhered to the style guide.

After submitting your PR:

[x] Update the Changelog.md file with a link to your PR.
[x] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

cdparks commented 3 years ago

@belevy let me know if I bumped the version/updated the changelog correctly

belevy commented 3 years ago

Yah, this is fixing a bug that was introduced. The behavior isnt new. I think the minor bump is fine.

belevy commented 3 years ago

Thank you for the fix :D

bitemyapp / esqueleto