Missing Instances for `:&` - bug or feature?

bitemyapp / esqueleto

New home of Esqueleto, please file issues so we can get things caught up!

BSD 3-Clause "New" or "Revised" License

376 stars 108 forks source link

Missing Instances for `:&` - bug or feature? #290

Closed m4dc4p closed 3 years ago

m4dc4p commented 3 years ago

In writing some queries, I've found a need for ToAlias/ToAliasReference/SqlSelect instances for the :& type. There are already instances of those classes for (,), (,,), and so on, and :& doesn't really seem any different.

Is this an oversight or is there some reason those instances aren't defined for :&?

Thanks!

(I'm using 3.4.2.1 so please let me know if I just need to upgrade).

parsonsmatt commented 3 years ago

Definitely a bug/oversight if we're supporting (,,) in places but not :&

There's a SqlSelect instance in a new version

m4dc4p commented 3 years ago

Much appreciated!

parsonsmatt commented 3 years ago

We should still implement ToAlias and ToAliasReference, I think :)

m4dc4p commented 3 years ago

My PR is up but needs approval to run CI on it.

m4dc4p commented 3 years ago

Thanks for accepting this one!