Add missing instances to (:&)

m4dc4p commented 2 years ago

The (:&) operator has an instance for SqlSelect, but none for ToAlias and ToAliasReference. Adding those for parity.

I'm not sure if the should be a patch or major version bump. Adding new instances can break existing code, but they are such small instances ... I guessed and bumped the patch number.

I was unable to get the testing environment working locally, so I was going to rely on CI to execute my tests. 🤞

Related to #290.

[x] Bumped the version number.
[x] Added @since declarations to the Haddock.
[x] Ran stylish-haskell and otherwise adhered to the style guide.

After submitting your PR:

[ ] Update the Changelog.md file with a link to your PR.
[ ] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

m4dc4p commented 2 years ago

Updates made.

parsonsmatt commented 2 years ago

awesome, thank you!

m4dc4p commented 2 years ago

Would you approve the workflow again so CI will run? Apparently this will have to happen each time I push :/

parsonsmatt commented 2 years ago

going to merge and fix locally, thanks for the contribution! 😄

bitemyapp / esqueleto

Add missing instances to (:&) #291