Add test and fix for issue 299

bitemyapp / esqueleto

New home of Esqueleto, please file issues so we can get things caught up!

BSD 3-Clause "New" or "Revised" License

370 stars 107 forks source link

Add test and fix for issue 299 #334

Closed belevy closed 1 year ago

belevy commented 1 year ago

@parsonsmatt This should fix #299 by aggressively re-aliasing. Previously, if an already aliased value was discovered it would not be realiased. This caused an issue where an alias from a lower level could be mixed with an alias from a higher level. This only showed up as an issue when using set operations due to its "smarts" that try to avoid using more Idents than absolutely necessary.

I guess this is a minor version bump?

I would like your eyes on this before I merge.

parsonsmatt commented 1 year ago

As for version - there shouldn't be any changes to the behavior of the library, up to alpha equivalence on SQL queries. And it's a bug fix, not a new feature. I'd probably do a patch release.