bitemyapp / esqueleto

New home of Esqueleto, please file issues so we can get things caught up!
BSD 3-Clause "New" or "Revised" License
376 stars 108 forks source link

Generate `ToMaybe` in `deriveEsqueletoRecord` #378

Closed halogenandtoast closed 1 year ago

halogenandtoast commented 1 year ago

replaces #370

After submitting your PR:

halogenandtoast commented 1 year ago

Opening this up for conversation since the draft didn't get eyes and I think this is nearly there.

halogenandtoast commented 1 year ago

@parsonsmatt did you mean something different from: https://github.com/bitemyapp/esqueleto/pull/378/files#diff-bef0a2133965554f3b49d699a015a29f235548c9ae5edc52ce80cd348332720dR282-R300

halogenandtoast commented 1 year ago

Confirmed this compiles and all existing tests run and pass on 8.10.7

halogenandtoast commented 1 year ago

I don't have a machine I can run 8.6.5 on until November 4th so fixing this will have to wait until then unless someone else can do the update here.