This PR fixes #359 by always wrapping arguments to not_ in parentheses when building SQL queries. Some tests combining not_ with &&. and ||. have also been added to Common.Test.
This is technically a breaking change: not_ (x &&. y) is no longer equivalent to (not_ x) &&. y, for example, although the equivalence is probably unintended.
Before submitting your PR, check that you've:
[ ] Bumped the version number.
[x] Ran stylish-haskell and otherwise adhered to the style guide.
stylish-haskell fails to parse the DEPRECATED pragma for sub_select in Database.Esqueleto.Internal.Internal.
After submitting your PR:
[ ] Update the Changelog.md file with a link to your PR.
[ ] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).
This PR fixes #359 by always wrapping arguments to
not_in parentheses when building SQL queries. Some tests combiningnot_with&&.and||.have also been added toCommon.Test.This is technically a breaking change:
not_ (x &&. y)is no longer equivalent to(not_ x) &&. y, for example, although the equivalence is probably unintended.Before submitting your PR, check that you've:
stylish-haskelland otherwise adhered to the style guide.stylish-haskellfails to parse theDEPRECATEDpragma forsub_selectinDatabase.Esqueleto.Internal.Internal.After submitting your PR: