search

bitemyapp / revise

RethinkDB client for Clojure
146 stars 8 forks source link

Deprecate protobufs? #22

Open cesarbp opened 10 years ago

cesarbp commented 10 years ago

Was wondering if people were ok with completely deleting the dependency on protobufs. It would force people to use Rethinkdb >=1.13 to use the latest revise version. Keeping the protobufs is a little more work on the short term. In the long term, the query namespace can be rewritten to optimise for the whole JSON stuff with the protobuf stuff out of the way.

danielytics commented 10 years ago

:+1: I'm ok with using latest RethinkDB. It seems that the JSON interface is the way to go for future RethinkDB versions anyway.

Btw, if you need help with bringing Revise up to date with latest RethinkDB, let me know. I'll need some guidance as to what to do, but I'm willing to help.

cesarbp commented 10 years ago

You could help by adding support for joda time. Rethinkdb wants date inputs as strings

danielytics commented 10 years ago

Ok. I will start looking at this over the weekend.