biter777 / countries

Countries - ISO-639, ISO-3166 countries codes with subdivisions and names, ISO-4217 currency designators, ITU-T E.164 IDD phone codes, countries capitals, UN M.49 codes, IANA ccTLD countries domains, FIPS, IOC/NOC and FIFA codes, VERY VERY FAST, compatible with Databases/JSON/BSON/GOB/XML/CSV, Emoji countries flags and currencies, Unicode CLDR.
https://pkg.go.dev/github.com/biter777/countries?tab=doc
BSD 2-Clause "Simplified" License
390 stars 74 forks source link

ISO-4217: Replace old belarussian ruble BYR with BYN #34

Closed futuarmo closed 2 years ago

futuarmo commented 2 years ago

Replaced old BYR to BYN according to ISO 4217 https://en.wikipedia.org/wiki/ISO_4217

futuarmo commented 2 years ago

@biter777 @gavincarr @benja-M-1 @jufemaiz Please, review. Looks like something wrong with Scrutinizer

jufemaiz commented 2 years ago

LGTM. Only thing I'm not 100% sure about is how github.com/biter777/countries handles historic values. @biter777 ?

futuarmo commented 2 years ago

There is no any way to handle historic values in package now as I see

biter777 commented 2 years ago

Done