search

biter777 / countries

Countries - ISO-639, ISO-3166 countries codes with subdivisions and names, ISO-4217 currency designators, ITU-T E.164 IDD phone codes, countries capitals, UN M.49 codes, IANA ccTLD countries domains, FIPS, IOC/NOC and FIFA codes, VERY VERY FAST, compatible with Databases/JSON/BSON/GOB/XML/CSV, Emoji countries flags and currencies, Unicode CLDR.
https://pkg.go.dev/github.com/biter777/countries?tab=doc
BSD 2-Clause "Simplified" License
390 stars 74 forks source link

countries: fix Brazil country code. fix #51 #52

Closed zignd closed 1 year ago

zignd commented 1 year ago

Hi there @biter777!

This pull request is intended to fix issue #51. The issue author is my coworker and this fix is particularly important for the system we are working on.

The previous pull request related to Brazil's code introduced this bug, in an attempt to fix another bug. But I believe both bugs are now fixed in this new pull request, both Brazil's country code (76) and currency code (986).

For reference, this webpage can be checked regarding the correct codes for Brazil.

Thanks!

netlify[bot] commented 1 year ago

Deploy Preview for biter777countries ready!

Name Link
Latest commit cfdf7961ff23a726a1f1e2b938acd08520cc2a88
Latest deploy log https://app.netlify.com/sites/biter777countries/deploys/64831ac358739f00082030b2
Deploy Preview https://deploy-preview-52--biter777countries.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

zignd commented 1 year ago

@biter777 it seems that Scrutinizer is failing in the CI pipeline, but I checked the tests with go test -v ./... and it's passing. Your review would be greatly appreciated.

biter777 commented 1 year ago

Done!