search

biter777 / countries

Countries - ISO-639, ISO-3166 countries codes with subdivisions and names, ISO-4217 currency designators, ITU-T E.164 IDD phone codes, countries capitals, UN M.49 codes, IANA ccTLD countries domains, FIPS, IOC/NOC and FIFA codes, VERY VERY FAST, compatible with Databases/JSON/BSON/GOB/XML/CSV, Emoji countries flags and currencies, Unicode CLDR.
https://pkg.go.dev/github.com/biter777/countries?tab=doc
BSD 2-Clause "Simplified" License
390 stars 74 forks source link

fix: Two country typos #72

Closed effati closed 3 months ago

netlify[bot] commented 3 months ago

Deploy Preview for biter777countries ready!

Name Link
Latest commit 45c5d00ae1810cfda6bf5d6e0d0a84101dbaf5c9
Latest deploy log https://app.netlify.com/sites/biter777countries/deploys/66507fb267a7700008a0bdc3
Deploy Preview https://deploy-preview-72--biter777countries.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ccoVeille commented 3 months ago

While your change is legitimate, I'm a bit afraid about the effect of this breaking change

So maybe the old const could be created at the end with a deprecated syntax

Something like, your exact PR plus

        // Deprecated: CongoDemocracticRepublicCountryCode old const with a typo
         CongoDemocracticRepublicCountryCode = CongoDemocracticRepublicCountryCode

The deprecated comment is standard, gopls, so almost IDE handles it

I'm not a maintainer, just a random gopher

biter777 commented 3 months ago

Ok Thnx

ccoVeille commented 3 months ago

@biter777

You said OK, but merged without doing any changes.

https://github.com/biter777/countries/pull/72#issuecomment-2129385143

Do you plan to do it?