bitextor / pdf-extract

PDF parser and converter to HTML
GNU General Public License v3.0
83 stars 14 forks source link

Error handling #34

Closed kpu closed 4 years ago

kpu commented 4 years ago

These functions to parse numbers that default to 0 smell bad. Why would null be passed; isn't that a logic error? There's a risk that bugs in other parts of the code are being hidden by this code.

https://github.com/bitextor/pdf-extract/blob/4ad28a23817851355ba65b6b4699a8f01b2cb760/src/pdfextract/Common.java#L161