search

bitfield / uptimerobot

Client library for UptimeRobot v2 API
MIT License
56 stars 11 forks source link

Implement pagination for monitors #1

Closed bitfield closed 5 years ago

bitfield commented 6 years ago

The UptimeRobot API paginates responses to getMonitors and getAlertContacts, sending (I think) 50 items at a time. The library needs to handle this and return all results (currently it returns only the first page of results).

alandotcom commented 5 years ago

I think I have a working solution here, for get monitors:

https://github.com/bitfield/uptimerobot/compare/master...lumberj:pagination?expand=1

bitfield commented 5 years ago

Changing this issue to just require pagination for monitors. There are probably a lot more monitors than there are alert contacts! If anyone wants pagination for alert contacts too, they're welcome to open an issue for it (and we can use the same machinery).