bitfield / uptimerobot

Client library for UptimeRobot v2 API
MIT License
56 stars 11 forks source link

Add way to set monitoring interval and contact delay on monitors via cli #18

Open Yggdrasil opened 4 years ago

Yggdrasil commented 4 years ago

Hi @bitfield,

When I create monitors manually I like to set the following features:

Would it be possible to add parameters to the CLI ensure and new commands to apply those settings?

bitfield commented 4 years ago

Hey @Yggdrasil! Thanks for opening the issue, much appreciated.

The monitoring interval is something we should definitely support, in both the library and the CLI tool. I've opened this as #19.

A delay before notifying a specific contact is not something that I can see support for in the Uptime Robot API, but if I'm wrong about that, let me know. There is provision for a threshold and recurrence value, for Pro Plan users, to have the monitor wait X minutes before notifying (to all contacts), and optionally re-notify every Y minutes: https://blog.uptimerobot.com/new-feature-advanced-notification-options-for-the-pro-plan/

I've opened issue #20 to add support for these.

Let me know if this covers all your requirements (or doesn't!)

Yggdrasil commented 4 years ago

Thanks @bitfield. Much appreciated.

That threshold and recurrence is indeed when I meant. I didn't realize that's what they were called. I wouldn't dream of asking you to support features that are not present in Uptimerobot itself. ;)

bitfield commented 4 years ago

Not a problem. I'll get to work on those!