REST API v2 Authenticator

bitfinexcom / bitfinex-api-go

BITFINEX Go trading API - Bitcoin, Litecoin, and Ether exchange

https://www.bitfinex.com/

MIT License

309 stars 220 forks source link

REST API v2 Authenticator #109

Closed mlensment closed 6 years ago

mlensment commented 6 years ago

Adds Authentication interface for v2 REST client;
Uses authenticated requests for orders All and orders History;
Supports (optional) parameters;
Supports custom nonce generator;
Backwards compatible;
Easy to integrate with other endpoints as well;
Improved README;
Improved orders example;
Tests for the Authenticator.

brobits commented 6 years ago

thanks for these updates! by the time I noticed this PR, I had already written these updates: https://github.com/brobits/bitfinex-api-go/commit/8b19f0dafc7a213f1dc6598b65855b4701b75b3b

I'm open to feedback on these changes vs. my recent commit

jvatianou-connamara commented 6 years ago

Moving this to 'review/qa' pipeline.

There seems to be quite a bit of conflicts with the PR. Before this is considered, we should get a 'no conflicts' message from Github.

mlensment commented 6 years ago

Moving this to 'review/qa' pipeline.

There seems to be quite a bit of conflicts with the PR. Before this is considered, we should get a 'no conflicts' message from Github.

I don't think this is ever getting merged so I'm closing this PR. They implemented some of this pull request's features themselves 2 days after I posted this.