search

bitfinexcom / bitfinex-api-go

BITFINEX Go trading API - Bitcoin, Litecoin, and Ether exchange
https://www.bitfinex.com/
MIT License
310 stars 220 forks source link

v2 Candles API returns incomplete data #122

Open utdrmac opened 6 years ago

utdrmac commented 6 years ago

If the candle at time index X and X+1 have the same data (ie: no chart movement), API does not include candle X+1. This shows time "blanks" when examining the data. Cannot find documentation of this non-standard behavior. I say non-standard because none of the other major exchanges operate this way. At other exchanges, all time slices are always returned regardless if the data is the same or not. The API example code does not dive into this either. How are you supposed to handle this "missing data" issue?

danny408 commented 6 years ago

Where did you even find the candles api in v2?

utdrmac commented 6 years ago

@dannyluong408 klines == candles

danny408 commented 6 years ago

ah i was looking for a rest version :|

utdrmac commented 6 years ago

@dannyluong408 There is. https://api.bitfinex.com/v2/candles/trade:5m:tTNBBTC/hist

danny408 commented 6 years ago

@utdrmac yea i know but it isnt available in this repo, didnt wanna have to learn some go and write it but i guess ill learn

wyaeld commented 6 years ago

Candle rest api is implemented in this PR https://github.com/bitfinexcom/bitfinex-api-go/pull/115 I'm just trying to work with the new maintainer to get it merged in. You're welcome to try it out, and if you find any issues report them on the PR

jvatianou-connamara commented 6 years ago

@dannyluong408 @wyaeld

Pr #115 is now merged.

Let me know how it looks and I can also close this issue.

Thank you.