search

bitfinexcom / bitfinex-api-go

BITFINEX Go trading API - Bitcoin, Litecoin, and Ether exchange
https://www.bitfinex.com/
MIT License
303 stars 222 forks source link

Adding LedgerService #165

Closed remco-remco closed 5 years ago

remco-remco commented 5 years ago
JacobPlaster commented 5 years ago

Hey @remco-remco, thanks for opening a PR, this all looks good. Could you please squash the commits and add a meaningful commit message such as v2/rest: adds support for ledger endpoint?

remco-remco commented 5 years ago

Hey @remco-remco, thanks for opening a PR, this all looks good. Could you please squash the commits and add a meaningful commit message such as v2/rest: adds support for ledger endpoint?

Hi Jacob, thanks! I'm very new to github and a bit new to golang.

I also tried to add an example how to use the ledgerservice. it works perfectly on my local pc but it fails testing on github, I decided to remove the example for the moment.

JacobPlaster commented 5 years ago

@remco-remco ok thats no problem. This repo uses travis as a build gateway and runs the following commands golangci-lint run and go test -v ./... whenever you update your PR. If either of these fail then the build will fail and you will get that horrible red cross.

When pushing new changes run golangci-lint run and go test -v ./... and if they pass locally then the build will pass on travis.

remco-remco commented 5 years ago

@remco-remco ok thats no problem. This repo uses travis as a build gateway and runs the following commands golangci-lint run and go test -v ./... whenever you update your PR. If either of these fail then the build will fail and you will get that horrible red cross.

When pushing new changes run golangci-lint run and go test -v ./... and if they pass locally then the build will pass on travis.

Ok, thanks!

remco-remco commented 5 years ago

I have nothing else to add at the moment. Hope everything looks good for implementation :-)

JacobPlaster commented 5 years ago

Looks fine @remco-remco, Im just going to manually test this and ill pass it on to get merged. Thanks again for the work!

remco-remco commented 5 years ago

Looks fine @remco-remco, Im just going to manually test this and ill pass it on to get merged. Thanks again for the work!

Excellent! I'm already using this new function in one of my apps. So far it works great.

Thank you too for helping me with this merge!