search

bitfinexcom / bitfinex-api-go

BITFINEX Go trading API - Bitcoin, Litecoin, and Ether exchange
https://www.bitfinex.com/
MIT License
303 stars 222 forks source link

c.log.Errorf/Debugf/Warningf missing #182

Open gpmn opened 5 years ago

gpmn commented 5 years ago

Issue type

Brief description

compile failed, since the c.log.Errorf/Debugf/Warningf ..... not defined.

I have update my local repository to the latest, but still missing such functions. And I checked godoc for logging module, it seems it do not support such functions indeed. Could you double check your code? And I wish you could use goroot/src/log/ module instead of godoc.org/cloud.google.com/go/logging. Original log module is simple and enough, I suppose .......

Steps to reproduce

-

cd $GOPATH/github.com/bitfinexcom/bitfinex-api-go/v2/websocket

go build -v && go test -v && go vet

Additional Notes:

-

https://godoc.org/cloud.google.com/go/logging

go build -v && go test -v && go vet github.com/bitfinexcom/bitfinex-api-go/v2/websocket

github.com/bitfinexcom/bitfinex-api-go/v2/websocket

./channels.go:43:6: undefined: vtdffffffff ./channels.go:44:11: c.log.Error undefined (type "cloud.google.com/go/logging".Logger has no field or method Error) ./channels.go:71:9: c.log.Debugf undefined (type "cloud.google.com/go/logging".Logger has no field or method Debugf) ./channels.go:73:9: c.log.Warningf undefined (type "cloud.google.com/go/logging".Logger has no field or method Warningf) ./channels.go:87:10: c.log.Warningf undefined (type "cloud.google.com/go/logging".Logger has no field or method Warningf) ./channels.go:134:9: c.log.Warningf undefined (type "cloud.google.com/go/logging".Logger has no field or method Warningf) ./channels.go:432:8: c.log.Warningf undefined (type "cloud.google.com/go/logging".Logger has no field or method Warningf) ./client.go:100:72: cannot use w.parameters.Logger (type "github.com/op/go-logging".Logger) as type "cloud.google.com/go/logging".Logger in argument to newWs ./client.go:200:67: cannot use params.Logger (type "github.com/op/go-logging".Logger) as type "cloud.google.com/go/logging".Logger in argument to newSubscriptions ./client.go:209:3: cannot use params.Logger (type "github.com/op/go-logging".Logger) as type "cloud.google.com/go/logging".Logger in field value ./client.go:209:3: too many errors

gpmn commented 5 years ago

I found cause, logging module not referred correctly, please change the import path.

in these 3 files : client.go subscriptions.go transport.go

change FROM "cloud.google.com/go/logging" TO "github.com/op/go-logging"