Update json tags for Credit to reflect REST response

bitfinexcom / bitfinex-api-go

BITFINEX Go trading API - Bitcoin, Litecoin, and Ether exchange

https://www.bitfinex.com/

MIT License

309 stars 220 forks source link

Update json tags for Credit to reflect REST response #190

Closed abrander closed 5 years ago

abrander commented 5 years ago

Description:

Some JSON fields are transferred as strings. This will update the struct tags to allow JSON unmarshaling as expected.

Breaking changes:

None. I hope.

New features:

client.Credits.All() is now usable.

Fixes:

Error json: cannot unmarshal string into Go struct field Credit.Rate of type float64 was thrown when trying to unmarshal REST response to bitfinex.Credit.

PR status:

[ ] Version bumped
[ ] Change-log updated

JacobPlaster commented 5 years ago

Hey @abrander thanks for he PR. We can get this merged, but in the meantime have you tried the v2 funding rest endpoints?

JacobPlaster commented 5 years ago

Thanks @abrander