search

bitfinexcom / bitfinex-api-go

BITFINEX Go trading API - Bitcoin, Litecoin, and Ether exchange
https://www.bitfinex.com/
MIT License
303 stars 222 forks source link

feat: add funding period in trade result #209

Open fshiori opened 4 years ago

fshiori commented 4 years ago

Description:

... add funding period in trade result

Breaking changes:

none

New features:

Fixes:

none

PR status:

JacobPlaster commented 4 years ago

Hey @fshiori, thanks again for opening a PR!

What is the need for period in the trade object? Prehaps you should be using the FundingTrade type? https://github.com/bitfinexcom/bitfinex-api-go/blob/11d21c1fe662e3d688558ae3adc1aad72c11185b/v2/types.go#L1298

fshiori commented 4 years ago

FundingTrade used for different API.

FundingTrade is for https://docs.bitfinex.com/reference#rest-auth-funding-trades-hist and Trade is for https://docs.bitfinex.com/reference#rest-public-trades Although rest-auth-funding-trades-hist can instead of rest-public-trades API , but FundingService Trades seems not support query string start/end/limit now. It also need more work.