Trade execution update parsing error - Githubissues

bitfinexcom / bitfinex-api-go

BITFINEX Go trading API - Bitcoin, Litecoin, and Ether exchange

https://www.bitfinex.com/

MIT License

303 stars 222 forks source link

Trade execution update parsing error #220

Closed dnfd closed 3 years ago

dnfd commented 3 years ago

Issue type

[x] bug
[ ] missing functionality
[ ] performance
[ ] feature request

Brief description

Looks like trade execution update has one additional field now, lib does not parse this event anymore.

This one expected

[0,"tu",[402088407,"tETHUST",1574963975602,34938060782,-0.2,153.57,"MARKET",0,-1,-0.061668,"USD"]]

This one I get now

[0,"tu",[500513817,"tCHZUSD",1599145405293,50261323849,356,0.015955,"EXCHANGE FOK",0.017238,-1,-0.712,"CHZ",1599145405]]

Steps to reproduce

Do any trade and you get this error

&errors.errorString{s:"data slice too short for trade update: []interface {}{5.00513817e+08, \"tCHZUSD\", 1.599145405293e+12, 5.0261323849e+10, 356, 0.015955, \"EXCHANGE FOK\", 0.017238, -1, -0.712, \"CHZ\", 1.599145405e+09}"} component=engine-bitfinex

Additional Notes:

Also error is misleading, actual slice is too long in this case.

JacobPlaster commented 3 years ago

Hey @dnfd, this was fixed in https://github.com/bitfinexcom/bitfinex-api-go/pull/222 (v3.0.1)