search

bitfireAT / davx5-ose

DAVx⁵ is an open-source CalDAV/CardDAV suite and sync app for Android. You can also access your online files (WebDAV) with it.
https://www.davx5.com
GNU General Public License v3.0
1.27k stars 69 forks source link

LoginSetupActivity: allow http/https in intent filter #211

Closed AlvaroBrey closed 1 year ago

AlvaroBrey commented 1 year ago

Initially introduced in https://github.com/bitfireAT/davx5-ose/commit/054f1ece612eceef962b356b7ad8b2b7125a6393, this intent-filter breaks login from the Nextcloud app, as we send the server URI as http/https, and the intent resolution fails.

Closes https://github.com/nextcloud/android/issues/11126

Signed-off-by: Álvaro Brey alvaro.brey@nextcloud.com

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

rfc2822 commented 1 year ago

Hi,

Thanks for the PR! If I see it correctly, it would show "Open in DAVx5" for all HTTP(S) URLs from all apps, right? So DAVx5 would act like a browser.

Currently the implicit intent feature is designed to accept only caldav(s) and davx5 URLs for this reason (so that it doesn't open when only browsers or other generic HTTP(S) user agents should be listed): https://manual.davx5.com/integration.html#implicit-intent

In the explicit intent, http(s) should just work.

May I ask what the specific reason for the proposed change is? So that I can suggest a solution

(See below)

rfc2822 commented 1 year ago

We have found that it's a DAVx5 problem that has arised because we have recently (in 4.2.5) raised the target SDK level to Android 13. We're working on it. :)