[4.3.6.1] App crashes when opening AboutActivity

[rfc2822]

Discussed in https://github.com/bitfireAT/davx5-ose/discussions/398

^{Originally posted by **staryil** September 7, 2023} In the latest version the app is crashing when going to the About/License section...

[rfc2822]

We should make sure that

• [x] the translators list is filled with data,
• [ ] the About dialog / the translators tab doesn't crash on parsing exceptions (instead it could just be empty or show the exception message)

[ArnyminerZ]

I've tried manually building the app from gradle with my own keystore and using app:assembleRelease, and the issue is also not there. Only occurs with the Github build

[ArnyminerZ]

I can confirm the translators.json file is empty on release. To see:

1. Drag an drop the apk file into Android Studio.
2. In the apk analyzer window, search for assets/translators.json
3. The file is empty

[rfc2822]

I've tried manually building the app from gradle with my own keystore and using app:assembleRelease, and the issue is also not there. Only occurs with the Github build

It's related to the davx5-ose repo. You can try with the -ose repo and you should be able to reproduce it.

Seems that when I fetched the translations for davx5-ose the last time, the translators.json became empty: https://github.com/bitfireAT/davx5-ose/commit/b670979f12ccfc1c22521545dfd82c6f721e69a4

[ArnyminerZ]

Ooooh, yeah, totally: https://github.com/bitfireAT/davx5-ose/blob/dev-ose/app/src/main/assets/translators.json

[ArnyminerZ]

Then #401 should do the job

[rfc2822]

Then #401 should do the job

How did you get the list of translators? Does the API call just work again? Maybe it was a one-time empty result.

Then we should still address the second point:

the About dialog / the translators tab doesn't crash on parsing exceptions (instead it could just be empty or show the exception message)