search

bitfireAT / davx5-ose

DAVx⁵ is an open-source CalDAV/CardDAV suite and sync app for Android. You can also access your online files (WebDAV) with it.
https://www.davx5.com
GNU General Public License v3.0
1.27k stars 69 forks source link

Rewrite TasksFragment to Compose #481

Closed ArnyminerZ closed 5 months ago

ArnyminerZ commented 6 months ago

Should be ready. I've added a function in UiUtils that annotates HTML links for Compose. It's designed to kind of be extendable, for example, for bold and italics support. There's also a test called UiUtilsTest that makes sure it works correctly, since there are some edge cases with single characters at the end, for example, that should be covered and work properly.

Also the design of CardWithImage is made so that the actual content of the card can be customized depending on the needs, not just with RadioWithSwitch. I hope everything is clear, otherwise just ask 😄

ArnyminerZ commented 6 months ago

~TasksFragment is still a Fragment, if we want to get rid of Fragments, I can try to find a workaround~

I've removed TasksFragment completely, both TasksActivity and TasksIntroFragment instantiate their own composables. However, file naming or sorting might still be a bit strange, so please @rfc2822 feel free to suggest how to move things around.

ArnyminerZ commented 6 months ago

Also there's this at.bitfire.davdroid.ConcurrentUtilsTest > testRunSingle_SameKey_Parallel FAILED failing test. It's running fine on my computer, any ideas?

ArnyminerZ commented 5 months ago

@rfc2822 not sure why the test is failing. It passes on my computer 🤔