bitfireAT / davx5-ose

DAVx⁵ is an open-source CalDAV/CardDAV suite and sync app for Android. You can also access your online files (WebDAV) with it.
https://www.davx5.com
GNU General Public License v3.0
1.27k stars 69 forks source link

Remove unused string resources #651

Closed mbiebl closed 2 months ago

mbiebl commented 2 months ago

The list was computed in an automated way and includes:

intro_battery_not_whitelisted
intro_battery_whitelisted
permissions_jtx_status_off
permissions_jtx_status_on
about_flavor_info
about_translations_thanks
install_email_client
accounts_global_sync_disabled
accounts_global_sync_enable
app_settings_tasks_provider_synchronizing_with
account_no_address_books
account_no_calendars
account_no_webcals
account_swipe_down
account_create_new_address_book
account_create_new_calendar
settings_title
settings_enter_username
settings_enter_password
settings_key_default_alarm
certificate_notification_connection_security
trust_certificate_unknown_certificate_found
mbiebl commented 2 months ago

Please review the list carefully. It was created via grep/sed and might contain false positives.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

ArnyminerZ commented 2 months ago

@mbiebl please, sign the CLA

mbiebl commented 2 months ago

not sure about about_flavor_info btw and if it's needed for the custom builds. A lot of the strings though appear unused as a result of the ongoing Compose migration work.

rfc2822 commented 2 months ago

not sure about about_flavor_info btw and if it's needed for the custom builds.

Everything that isn't used in the ose flavor doesn't belong to this repo.

A lot of the strings though appear unused as a result of the ongoing Compose migration work.

Yes, there were a lot of changes and adaptions. While rewriting to Compose, many details have also be improved and thus strings have changed.