Added M3 theme to intro pages

ArnyminerZ commented 2 weeks ago

(See https://github.com/bitfireAT/davx5-ose/issues/691)

Purpose

Right now our M3 theme is not being used for intro pages.

Short description

Added AppTheme call in PageFragment.
Added a TODO to remember removing the old M2 theme once all migrations are complete for intro.

Checklist

[x] The PR has a proper title, description and label.
[x] I have self-reviewed the PR.
[x] I have added documentation to complex functions and functions that can be used by other modules.
[x] I have added reasonable tests or consciously decided to not add tests.

Depends on #739 Depends on #740 Depends on #741 Depends on #757 Depends on #759

sunkup commented 2 weeks ago

We shouldn't have M2Theme and AppTheme at the same time. We can merge this when all pages are rewritten and then only need AppTheme. I have set appropriate dependencies.

Okay, but why?

rfc2822 commented 2 weeks ago

I don't want to need multiple PRs for the same file for the rewrite except it's really required without alternative. But I'd prefer that no files are "in-between", but either "old" or "rewritten/finished".

github-actions[bot] commented 3 days ago

This PR/issue depends on:

~~bitfireAT/davx5-ose#739~~
~~bitfireAT/davx5-ose#740~~
~~bitfireAT/davx5-ose#741~~
~~bitfireAT/davx5-ose#757~~
~~bitfireAT/davx5-ose#759~~

bitfireAT / davx5-ose