Rewrite PermissionsIntroPage to M3 - Githubissues

bitfireAT / davx5-ose

DAVx⁵ is an open-source CalDAV/CardDAV suite and sync app for Android. You can also access your online files (WebDAV) with it.

https://www.davx5.com

GNU General Public License v3.0

1.25k stars 69 forks source link

Rewrite PermissionsIntroPage to M3 #758

Closed ArnyminerZ closed 2 weeks ago

ArnyminerZ commented 2 weeks ago

(See https://github.com/bitfireAT/davx5-ose/issues/691)

Purpose

Update design of the PermissionsIntroPage intro page (and PermissionsActivity) so that it uses M3.

[!Note] BasicTopAppBar still has to be migrated to M3. May be good to migrate it together with this PR since it basically has the same considerations as CardWithImage.

Short description

Replaced all M2 usages with M3 of PermissionsCardContent
Replaced all M2 usages with M3 of CardWithImage. More intro pages will benefit from this change. May have effects on #744, however, I haven't seen any modifications here, and this is a smaller PR, so maybe we should merge this here.
Forced all states in PermissionsActivity.Model to have private setters.

Checklist

[x] The PR has a proper title, description and label.
[x] I have self-reviewed the PR.
[x] I have added documentation to complex functions and functions that can be used by other modules.
[x] I have added reasonable tests or consciously decided to not add tests.

sunkup commented 2 weeks ago

~Will review the PR after its dependency has been merged~