search

bitfireAT / davx5-ose

DAVx⁵ is an open-source CalDAV/CardDAV suite and sync app for Android. You can also access your online files (WebDAV) with it.
https://www.davx5.com
GNU General Public License v3.0
1.27k stars 69 forks source link

"Rename account" should use outlined text field #785

Closed mbiebl closed 2 weeks ago

mbiebl commented 3 weeks ago

Problem scope

App version

Android version and device/firmware type

not relevant

Steps to reproduce

Create an account then use the "Rename account" menu option. The upcoming dialog does not use an outlined text field.

Screenshot_20240508_150143

This is inconsistent as all other forms use outlined text fields

Expected result

Use an outlined text field in rename account dialog

Further info

No response

rfc2822 commented 3 weeks ago

Hm I actually decided to use the filled text field for that screen because it is the only text field, and is important for the (only) action. See https://m3.material.io/components/text-fields/guidelines

As with the buttons, where outlined buttons are used for less important actions and the filled button is used for important actions/the default action.

Is it that clear that this field should be outlined?

What do you think @devvv4ever ?

ArnyminerZ commented 3 weeks ago

Is it that clear that this field should be outlined?

No, I think you are right.

And if I'm not wrong, it's consistent amongst all dialogs, so I'd say just stick with what we have.

mbiebl commented 2 weeks ago 
$ grep TextField app/src/ -Rw
app/src/main/kotlin/at/bitfire/davdroid/ui/account/RenameAccountDialog.kt:import androidx.compose.material3.TextField
app/src/main/kotlin/at/bitfire/davdroid/ui/account/RenameAccountDialog.kt:            TextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/InputDialogs.kt:import androidx.compose.material.TextField
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/InputDialogs.kt:                TextField(

vs

$ grep OutlinedTextField app/src/ -Rw
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateCalendarScreen.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateCalendarScreen.kt:                        OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateCalendarScreen.kt:                    OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateCalendarScreen.kt:                        OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/HomeSetSelection.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/account/HomeSetSelection.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateAddressBookScreen.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateAddressBookScreen.kt:                    OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateAddressBookScreen.kt:                    OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/PasswordTextField.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/PasswordTextField.kt:    OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AccountDetailsPage.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AccountDetailsPage.kt:                OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/UrlLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/UrlLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/UrlLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/GoogleLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/GoogleLogin.kt:        OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/GoogleLogin.kt:        OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/NextcloudLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/NextcloudLogin.kt:                OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/EmailLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/EmailLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AdvancedLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AdvancedLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AdvancedLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountScreen.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountScreen.kt:                OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountScreen.kt:                OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountScreen.kt:                OutlinedTextField(
devvv4ever commented 2 weeks ago

It is debatable according to the M3 guidelines. Personally I prefer the filled versions of text fields like the one at the moment. But as we more or less use only outlined ones right now across the other app parts we should use the outlined version there too. We might want to consider using the other ones in the future ;-)