search

bitfireAT / davx5-ose

DAVx⁵ is an open-source CalDAV/CardDAV suite and sync app for Android. You can also access your online files (WebDAV) with it.
https://www.davx5.com
GNU General Public License v3.0
1.55k stars 77 forks source link

Replace AppIntro by Compose Pager #837

Closed rfc2822 closed 4 months ago

rfc2822 commented 5 months ago

We're currently using AppIntro which doesn't support Compose. As I understand it, all required functionality is provided by Compose Pager.

So we can replace AppIntro (and the fragments etc) by Pager, while keeping the intro screen composables as they are.

We should first define the steps to replace it. We should also try to keep the new implementation clean :)

rfc2822 commented 5 months ago

@ArnyminerZ I don't know how complicated this is … I think Compose Pager should support exactly our use case, and we already have the contents as Composables. So probably "only" the part with the Next/Back button is left. (And to change the code from AppIntro to Compose Pager of course.) Can you please check how much work this would be?

ArnyminerZ commented 5 months ago

I thought it was going to be harder tbh. I started tweaking around a bit to see how much work it would be, and turned out to be quite simple. I've created #848.

I have to say that maybe PositionIndicator is more complex than it really needs to be, but I think it looks really good. Maybe some adjustments can still be made nevertheless.