bitfireAT / davx5-ose

DAVx⁵ is an open-source CalDAV/CardDAV suite and sync app for Android. You can also access your online files (WebDAV) with it.
https://www.davx5.com
GNU General Public License v3.0
1.4k stars 72 forks source link

Calendar colors: Don't overwrite when not set by server #850

Closed rfc2822 closed 1 week ago

rfc2822 commented 2 months ago

Scope

Description

  1. When a server does not send a calendar color we don't need to overwrite it with our "green" every time (only use green when calendar is created). Users can then change the calendar color with a third party app and DAVx5 won't overwrite the changes.
  2. Maybe we shouldn't use green for all unknown calendars but select random? different colors. People don't see only green calendars then without possibility to distinguish between them.

Further info

Can we just not update the calendar color in LocalCalendar.update() when it's null from the server? (But of course set it in LocalCalendar.create, otherwise the calendar will be transparent)

djagoo commented 1 month ago

Or if it's not fully out of scope of the app, please integrate a color picker to set the calendar colors manually. I just disabled the calendar color sync in DAVx and noticed that even then the tasks.org app doesn't let me change the colors. The same with jtx. And the "Calendar Color" App mentioned on https://www.davx5.com/faq/change-calendar-color/ is very old and doesn't support tasks-lists without calendar.

Has anybody a workaround for my usecase? My caldav provider (vikunja) doesn't seem to support synced calendar colors atm.

christian179717 commented 1 week ago

Isn't that a bug? I don't want to force you to anything, and I'm thankful for developing, but after a while it's a bit annoying that the color changes always to complete different one, which I don't expect.

rfc2822 commented 1 week ago

~~Which one would you expect, when the server doesn't send one? Did you disable the "manage calendar colors" setting in the Account settings? Did you set them with a calendar app or a seperate app? Which one?~~

I think we have all necessary information