Update ical4j to 3.2.17

[rfc2822]

A test fails when updating to 3.2.15

• [x] Update to ical4j 3.2.15
• [x] Find out why the test is failing / fix it

Depends on https://github.com/ical4j/ical4j/issues/676 Depends on https://github.com/ical4j/ical4j/issues/678

[ArnyminerZ]

Looks like there's an issue with TZ aliases in the latest release of ical4j. Ben updated the loading method of aliases, and it seems like it broke something. See the change:

https://github.com/ical4j/ical4j/compare/ical4j-3.2.14..ical4j-3.2.15#diff-ca0f72d0501ea912d0342c8d541e40aade5c74a11fb65580fb308993aa9a4973

Calling:

DateUtils.ical4jTimeZone("GMT")

doesn't work, but calling

DateUtils.ical4jTimeZone("Etc/GMT")

does. If I forcefully update the test to do:

@Test
fun testLoadSystemTimezones() {
    for (id in ZoneId.getAvailableZoneIds()) {
        val name = ZoneId.of(id).getDisplayName(TextStyle.FULL, Locale.US)
        val info = try {
            DateUtils.ical4jTimeZone(
                if (id == "GMT") "Etc/GMT"
                else id
            )
        } catch(e: Exception) {
            Assert.fail("Invalid system timezone $name ($id)")
        }
        if (info == null)
            assertNotNull("ical4j can't load system timezone $name ($id)", info)
    }
}

It passes for GMT, but then Israel fails. Then I add else if (id == "Israel") "Asia/Jerusalem" and Israel works, but Greenwich fails. Looks definitely like a bug on their side.

[rfc2822]

It passes for GMT, but then Israel fails. Then I add else if (id == "Israel") "Asia/Jerusalem" and Israel works, but Greenwich fails. Looks definitely like a bug on their side.

Is it really a problem in ical4j or in Android compatibility / our Android timezone adapter? Could you please try to create a short test that illustrates the problem just with ical4j methods? If that's possible and shows a problem, we can report it at ical4j.

[ArnyminerZ]

Is it really a problem in ical4j or in Android compatibility / our Android timezone adapter?

I think it's a problem with ical4j, because these aliases are defined correctly, but it looks like they are not loaded correctly:

https://github.com/ical4j/ical4j/blob/ical4j-3.2.15/src/main/resources/net/fortuna/ical4j/model/tz.alias

[rfc2822]

Ok then please create an issue at ical4j with a short test that illustrates the problem (just loads the TZ), then we can set this issue as dependency of that one.

[ArnyminerZ]

Ben has released a fix for it in 3.2.16, see.

[ArnyminerZ]

Looks like it's fixed 😄

[rfc2822]

Great!

[ArnyminerZ]

@rfc2822 please can you take a look at the failing test? I'm not sure why it's there, there isn't anything at ICalPreprocessor that should replace that name afaik

[rfc2822]

@rfc2822 please can you take a look at the failing test? I'm not sure why it's there, there isn't anything at ICalPreprocessor that should replace that name afaik

ICalPreprocessor applies DatePropertyRule and DateListPropertyRule which are provided by ical4j. They call TzHelper.correctTzParameterFrom, which call getCorrectedTimeZoneIdFrom, which should somehow replace (English) MS time zone times by IANA tzdata ones.

Seems that this fails in 3.2.16 – probably because there were changes regarding this, which is also why 3.2.16 was released. So I think this should again be reported to ical4j (with a test that applies DatePropertyRule to a DTSTART with MS timezone; should replace the name with ical4j 3.2.14, but not with 3.2.16).

[ArnyminerZ]

I've reported it to Ben at https://github.com/ical4j/ical4j/issues/678

[github-actions[bot]]

This PR/issue depends on:

• ical4j/ical4j#676
• ical4j/ical4j#678

[rfc2822]

We can update to 3.2.17 :)