bitfireAT / ical4android

Allows usage of iCalendar files with the Android calendar provider
GNU General Public License v3.0
19 stars 10 forks source link

Updated ical4j to `3.2.10` #87

Closed ArnyminerZ closed 1 year ago

ArnyminerZ commented 1 year ago

Edit: Does not fix https://github.com/ical4j/ical4j/issues/454, does not fix https://github.com/bitfireAT/davx5/issues/165

leonggs commented 1 year ago

Recently, I've imported a third-party ics file to my Nextcloud calendar containing SEQUENCE:2302221158. It misuses the sequence field as booking date or something like that. All implementations such as ical4j that conform to the iCalendar RFC standard might fail parsing this encoding as 32 bit signed integers since 01.01.2022. Dear third-party, you have constructed a year2k, seriously? :D

Do this fix in the current issue fix my problem described above as well and will they be in the next release of Davx without further actions?

rfc2822 commented 1 year ago

Shall we merge it although it does not fix the original problem?

ArnyminerZ commented 1 year ago

Mmmh... Maybe... It's always good to have dependencies updated, there might be other bugfixes

rfc2822 commented 1 year ago

Agree…

There's a failing test though.

ArnyminerZ commented 1 year ago

The failing test is annotated with "should not fail in future", so it must have been fixed 😄

rfc2822 commented 1 year ago

Ah, nice, seems that it fixes a Persian Locale bug. Please keep the test to be sure in the future and just remove the failure expectation :)