search

bitfireAT / ical4android

Allows usage of iCalendar files with the Android calendar provider
GNU General Public License v3.0
19 stars 10 forks source link

Add geofence radius x property #97

Closed patrickunterwegs closed 1 year ago

patrickunterwegs commented 1 year ago

Hi @rfc2822 , the new tests obviously fail now because the version of jtx Board that contains those new fields doesn't exist yet as an apk. How would you like to proceed here? Would you like to accept that the test fails for now or should I deactivate them? A third option could maybe be to check the jtx Board version and skip the test if the version is old... (I'm not sure if this would work though for the android test)

rfc2822 commented 1 year ago

A third option could maybe be to check the jtx Board version and skip the test if the version is old... (I'm not sure if this would work though for the android test)

Sounds to be the most reasonable for me. You could JUnit Assume to skip the tests depending on the jtx Board version. But then we shouldn't forget to update the APK link as soon as the latest one is available ;)

patrickunterwegs commented 1 year ago

Alright, thanks, it's ready now 👍