Closed ArnyminerZ closed 1 month ago
Nevermind, Ricki says it's nice to try out here in ICSx5 already and should not cause complications when incorporating into DAVx5 :)
Perfect. In any case, there isn't much stored there, so really shouldn't matter for migration to DAVx5
Aaaand now tests are failing
Should be ready :)
Somethings seems to not work with the CI emulator tests, but the change is little. Looks good :)
Purpose
The ose version of ICSx5 shows a donation dialog every once in a while, which does have a correct working donation button, but once you hide it, it doesn't pop up again, and can't be invoked in any other way. If the one in the info activity is pressed, the same is shown both in gplay and standard, which doesn't contain any donation button to comply with Google Play's policy.
This dialog should be the same as the one that pops up automatically in standard.
Short description
The preferences have been migrated to
DataStore
since otherwise there's no easy way to access them from outside theDonateDialogService
for example.There's a migration function in
SubscriptionsModel
even though I don't think it's even worth it for what it migrates.Now in
InfoActivity
the services (ComposableStartupService
) are also initialized. If there's a service with theFLAG_DONATION_DIALOG
it's shown instead of the default "text dialog".Maybe the migration to DataStore is not mandatory for this fix, but I think it's useful, and may solve any future issues.
Checklist