Update to ez-vcard 0.12.0

bitfireAT / vcard4android

Allows usage of vCard resources with the Android contacts provider

GNU General Public License v3.0

11 stars 6 forks source link

Update to ez-vcard 0.12.0 #12

Closed ArnyminerZ closed 1 year ago

ArnyminerZ commented 1 year ago

I've replaced all Date references with LocalDate or LocalTime, as well as the deprecated Date(year, month, day, hour, minute) by the corresponding <Temporal>.of. Also now months start at 1 instead of 0, so some -1 were removed.

ArnyminerZ commented 1 year ago

Also, the PRODID has been updated to PRODID:ez-vcard 0.12.0 to match the new version.

rfc2822 commented 1 year ago

Sounds good.

Can you please check whether

[x] just using 0.12.0 without desugaring does not work in an Anroid <8, let's say Android 5, emulator with DAVx5 (just sync a test address book)
[x] and then your PR (with desugaring) makes it working?

ArnyminerZ commented 1 year ago

Without desugaring it simply doesn't compile since Temporal requires Java 8 and 0.12.0 uses this interface.

Basically it asks to increase sdk level

rfc2822 commented 1 year ago

… and the second part? Synchronizing contacts (with BDAY) with the ez-vcard 0.12 on an Android 5 emulator? Sometimes desugaring doesn't work as expected, and then we would get some strange exception instead of synchronized contacts (but only on old pre-Java-8 Android versions).

ArnyminerZ commented 1 year ago

Okay, I'll test asap

ArnyminerZ commented 1 year ago

Tests for vcard4android are passing successfully on a Nexus 6 API 19.

And I've tried DAVx⁵ with this branch for vcard4android, and birthdays are synchronized correctly: Screenshot_20230405_140609

Screenshot_20230405_140623

ArnyminerZ commented 1 year ago

~Now some tests are broken... I'll fix it~

Just a missing null-check