Moved to library

[ArnyminerZ]

@rfc2822 If I'm not wrong, this should be ready

[ArnyminerZ]

@rfc2822 please take a look at this. I think this is the recommended approach for Kotlin DSL

[rfc2822]

Looks good, but I wonder whether we even need the versions in a separate file. We use all version numbers only once, so maybe we should just put them into the dependency section (without extra file) and it's OK. Better less than more complexity.

Then I'll merge and then I suggest to use the lib from davx5 :)

[rfc2822]

As soon as we have this, it will also shorten compile time (and save runner time 💵) :)

As always, please just mark as ready for review & re-request review when ready

[ArnyminerZ]

It's being a bit tough. Jitpack kind of does what it wants, ignoring configuration sometimes. Looks like the "public" version works fine, but the CI configuration is not working properly, it tries to build with Java 8, which leads to errors

[rfc2822]

It's being a bit tough. Jitpack kind of does what it wants, ignoring configuration sometimes. Looks like the "public" version works fine, but the CI configuration is not working properly, it tries to build with Java 8, which leads to errors

We can just keep version "snapshot" in the maven file or something like that and determine it only by the commit ID. I'd just do that. Can we use "snapshot" or shall we use "0.0" or "1.0" or so?

[ArnyminerZ]

I'm taking a look at it right now. It seems that it's compiling correctly now. I'll try to use the library in DAVx5, and if everything is ready, I'll mark the PR as ready

[ArnyminerZ]

Looks like now it's good. Jitpack's logs show:

✅ Build artifacts:
com.github.bitfireAT:vcard4android:10ce796a0d

Which matches the commit ID from Github: 10ce796

[k3b]

@ArnyminerZ @rfc2822 can you add an example to readme.md how to use vcard4android as a gradle dependency ?

after some searching i finally found this example

implementation "com.github.bitfireAT:vcard4android:${versions.vcard4android}"